Commit Graph

174 Commits (master)

Author SHA1 Message Date
Eris Caffee db84d9e649 Issue 2766 Warn user of old MW version detected 3 years ago
Petr Mikheev fa29b9d6f7 Fix #6627 3 years ago
Bret Curtis 74e7cfc023 remove unused includes: part1
remove unused imports: part2

revert one tidy we will keep for c++20
3 years ago
psi29a 011a26684a Merge branch 'fix_wizard_dialogs' into 'master'
Fix wizard dialogs

See merge request OpenMW/openmw!1519
3 years ago
Josquin Frei 63a8bc5f9b Fix wizard dialogs 3 years ago
jvoisin 421e6629ad Fix unnecessary-copy-initialization
> warning: the variable 'key' is copy-constructed from a const reference but is
only used as const reference; consider making it a const reference
[performance-unnecessary-copy-initialization]

Found by clang-tidy.
3 years ago
pi03k e4eeb9cce9 Remove 'no relevant classes' moc warning 3 years ago
elsid e9b8933b2f
Do no link binaries with Qt where it's not used
Define components_qt static library with all qt dependent components that also
depends on other components. Link only cs, wizard and launcher with qt
dependent components.
3 years ago
Thunderforge efcdb2dfdd Using override keyword in most apps
Detected by clang-tidy's modernize-use-override

Future MRs can be created to run this on OpenMW and OpenMW CS
4 years ago
jvoisin fb55207328 Remove some useless includes from the wizzard 4 years ago
tess 6f7e8d9f59 Implement #3983 - Add page to the wizard with links to buy morrowind 4 years ago
uramer e7afbc74d8 Wizard: Only allow to select Morrowind.esm master files, display an error if Morrowind.bsa is missing 4 years ago
Alexei Dobrohotov ab789e37e1 Wizard: fix "file is already opened" warning 4 years ago
Andrei Kortunov 8084a336b5 Replace zeroes and nulls by nullptrs 4 years ago
Andrei Kortunov 8ca3c3b123 Mark overrided methods by override keyword 4 years ago
Andrei Kortunov 19e95afc42 Avoid reverse iteration on QHash 5 years ago
Andrei Kortunov 98bb73ffb7 Do not use deprecated QTextStream::endl 5 years ago
Bret Curtis 61a5c6125d #5480: Drop Qt4 support and require Qt 5.12 or later. 5 years ago
Capostrophic 9106e3646c Fix outdated bug tracker links 5 years ago
Capostrophic 21c49ca1b0 Make Wizard less shy (bug #4493) 5 years ago
elsid 045ceeac11
Replace foreach macro by for-loop 5 years ago
Andrei Kortunov 80c62a4fe1 Fix endsWith() call 6 years ago
Artur Rojek f6e1aaae1a Use case-insensitive compare when searching for game data by the wizard.
Until now, the wizard was only comparing against an exact file name
match while searching for game data, eg. "data*.cab".
This patch makes it possible to locate game data regardless of case
sensitivity, eg. "Data*.cab".
6 years ago
mp3butcher 9de6c630f2 fix moc achieving to reach unparsable boost code 6 years ago
Andrei Kortunov ad36834671 Fix some compiler warnings 6 years ago
Andrei Kortunov e06f0b797a Replace all NULLs to nullptr 6 years ago
Marc Zinnschlag d92d754834 Merged pull request #1697 7 years ago
tri4ng1e f2613a74b1
Write settings before invoking openmw-iniimporter 7 years ago
tri4ng1e d4d1703bcf
Some PVS-Studio and cppcheck fixes
cppcheck:
[apps/esmtool/record.cpp:697]: (performance) Prefer prefix ++/-- operators for non-primitive types.
[apps/esmtool/record.cpp:1126]: (performance) Prefer prefix ++/-- operators for non-primitive types.
[apps/esmtool/record.cpp:1138]: (performance) Prefer prefix ++/-- operators for non-primitive types.
[apps/niftest/niftest.cpp:36]: (performance) Function parameter 'filename' should be passed by reference.
[apps/niftest/niftest.cpp:41]: (performance) Function parameter 'filename' should be passed by reference.
[apps/opencs/model/prefs/boolsetting.cpp:25]: (warning) Possible leak in public function. The pointer 'mWidget' is not deallocated before it is allocated.
[apps/opencs/model/prefs/shortcuteventhandler.cpp:52]: (warning) Return value of std::remove() ignored. Elements remain in container.
[apps/openmw/mwstate/quicksavemanager.cpp:5]: (performance) Variable 'mSaveName' is assigned in constructor body. Consider performing initialization in initialization list.

PVS-Studio:
apps/opencs/model/filter/parser.cpp  582  warn  V560 A part of conditional expression is always true: allowPredefined.
apps/opencs/view/world/referencecreator.cpp  67  warn  V547 Expression '!errors.empty()' is always false.
apps/opencs/view/world/referencecreator.cpp  74  warn  V547 Expression '!errors.empty()' is always false.
apps/opencs/view/doc/loader.cpp  170  warn  V560 A part of conditional expression is always true: !completed.
apps/opencs/view/doc/loader.cpp  170  warn  V560 A part of conditional expression is always true: !error.empty().
apps/opencs/model/tools/pathgridcheck.cpp  32  err  V517 The use of 'if (A) {...} else if (A) {...}' pattern was detected. There is a probability of logical error presence. Check lines: 32, 34.
apps/opencs/model/world/refidadapterimp.cpp  1376  err  V547 Expression 'subColIndex < 3' is always true.

apps/openmw/mwgui/widgets.hpp  318  warn  V703 It is odd that the 'mEnableRepeat' field in derived class 'MWScrollBar' overwrites field in base class 'ScrollBar'. Check lines: widgets.hpp:318, MyGUI_ScrollBar.h:179.
apps/openmw/mwgui/widgets.hpp  319  warn  V703 It is odd that the 'mRepeatTriggerTime' field in derived class 'MWScrollBar' overwrites field in base class 'ScrollBar'. Check lines: widgets.hpp:319, MyGUI_ScrollBar.h:180.
apps/openmw/mwgui/widgets.hpp  320  warn  V703 It is odd that the 'mRepeatStepTime' field in derived class 'MWScrollBar' overwrites field in base class 'ScrollBar'. Check lines: widgets.hpp:320, MyGUI_ScrollBar.h:181
apps/openmw/mwmechanics/actors.cpp  1425  warn  V547 Expression '!detected' is always true.
apps/openmw/mwmechanics/character.cpp  2155  err  V547 Expression 'mode == 0' is always true.
apps/openmw/mwmechanics/character.cpp  1192  warn  V592 The expression was enclosed by parentheses twice: ((expression)). One pair of parentheses is unnecessary or misprint is present.
apps/openmw/mwmechanics/character.cpp  521  warn  V560 A part of conditional expression is always true: (idle == mIdleState).
apps/openmw/mwmechanics/pathfinding.cpp  317  err  V547 Expression 'mPath.size() >= 2' is always true.
apps/openmw/mwscript/interpretercontext.cpp  409  warn  V560 A part of conditional expression is always false: rank > 9.
apps/openmw/mwgui/windowbase.cpp  28  warn  V560 A part of conditional expression is always true: !visible.
apps/openmw/mwgui/journalwindow.cpp  561  warn  V547 Expression '!mAllQuests' is always false.
apps/openmw/mwgui/referenceinterface.cpp  18  warn  V571 Recurring check. The '!mPtr.isEmpty()' condition was already verified in line 16.
apps/openmw/mwworld/scene.cpp  463  warn  V547 Expression 'adjustPlayerPos' is always true.
apps/openmw/mwworld/worldimp.cpp  409  err  V766 An item with the same key '"sCompanionShare"' has already been added.
apps/openmw/mwworld/cellstore.cpp  691  warn  V519 The 'state.mWaterLevel' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 689, 691.
apps/openmw/mwworld/weather.cpp  1125  warn  V519 The 'mResult.mParticleEffect' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 1123, 1125.
apps/openmw/mwworld/weather.cpp  1137  warn  V519 The 'mResult.mParticleEffect' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 1135, 1137.

apps/wizard/unshield/unshieldworker.cpp  475  warn  V728 An excessive check can be simplified. The '(A && B) || (!A && !B)' expression is equivalent to the 'bool(A) == bool(B)' expression.
apps/wizard/installationpage.cpp  163  warn  V735 Possibly an incorrect HTML. The "</p" closing tag was encountered, while the "</span" tag was expected.

components/fontloader/fontloader.cpp  427  err  V547 Expression 'i == 1' is always true.
components/nifosg/nifloader.cpp  282  warn  V519 The 'created' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 278, 282.
components/esm/loadregn.cpp  119  err  V586 The 'clear' function is called twice for deallocation of the same resource. Check lines: 112, 119.
components/esm/cellref.cpp  178  warn  V581 The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 175, 178.
components/esmterrain/storage.cpp  235  warn  V560 A part of conditional expression is always true: colStart == 0.
components/esmterrain/storage.cpp  237  warn  V560 A part of conditional expression is always true: rowStart == 0.
7 years ago
Andreas Sturmlechner 2c9d46a60b
Fix build with Qt 5.11_beta3 (dropping qt5_use_modules) 7 years ago
Capostrophic 5a3086b0c6
Auto-detect the actual Morrowind assets path (Fixes #4336) 7 years ago
scrawl 80f7279a4d
Change default installation directory from 'data' to 'basedata' (Bug #3557) 7 years ago
AnyOldName3 5ce34f1cbf Move new behaviour into macro to reduce code duplication 7 years ago
AnyOldName3 3c0ec0d6d0 If CMake supports it, sets the debugger working directory for Visual Studio 7 years ago
Thunderforge f41a4bb937 Changing "New Installation" to "Retail CD/DVD" for clarity 7 years ago
Siimacore 6af470ff03 Stopping the thread in the wizard that prevented it to stop correctly 8 years ago
Leon Krieg c7b4b2cdd7 Fixed multiple spelling mistakes 8 years ago
scrawl 5297d7b5be Merge pull request #1137 from nikolaykasyanov/osx-structure
[macOS] Move all resources files inside application bundles (fixes #3566)
8 years ago
Nikolay Kasyanov db69342b5d [macOS] Move all configs & resources into app bundles
Fixes #3566 (https://bugs.openmw.org/issues/3566).
8 years ago
scrawl 9d125bcaa2 Merge pull request #1129 from PhillipAnd/phillipand-cmake-fix
Fix various build issues with Visual Studio environment
8 years ago
Phillip Andrews aeaedbc57a Moved install commands to target-specific cmakelists so that all configurations work. 8 years ago
Allofich 3420121c3f Fix shadowing warnings 8 years ago
scrawl e0f613661e Fix char -> int, fix shadowing warning 8 years ago
Allofich 125e94ef0e Fix shadowing warnings 8 years ago
Mikhail Korolev 7e2fe77836 apps/wizard: (trivial) fix misplaced arguments in installFile for installFiles 8 years ago
David Carlier 83bab29e4b Mainly making compilable under OpenBSD.
Renaming one resource file as the space led to issue for qt/moc.
9 years ago
Roman Proskuryakov edb41b5b08 Rewrites FindLIBUNSHIELD using LibFindMacros
Renames LIBUNSHIELD_INCLUDE_DIR -> LIBUNSHIELD_INCLUDE_DIRS, LIBUNSHIELD_LIBRARY -> LIBUNSHIELD_LIBRARIES
9 years ago
Alexander "Ace" Olofsson fe241be26c Merge branch 'master' of git://github.com/OpenMW/openmw into appveyor 9 years ago
Alexander "Ace" Olofsson 2142d0d2d6 Make Qt5 happy 9 years ago
scrawl 2f9b404094 InstallationPage: properly exit the QThread (Fixes #2210) 9 years ago
scrawl 2ffcc2a2b4 Fix incorrect path encoding handling in debug message 9 years ago
scrawl 609e146a22 Build fixes for windows 10 years ago
scrawl e13a938896 Add support to build with Qt5 (Task #2665)
Known issue: the render view doesn't work in Qt5. With the switch to OSG around the corner, this isn't worth fixing.
10 years ago
scrawl 4b5c2398a1 Remove QTextCodec::setCodecForCStrings
Not needed, we're using QString::fromUtf8/toUtf8 to handle encodings correctly.
10 years ago
scrawl cf95d3fc35 Refactor cmake scripts, reducing the amount of find_package(Boost) 10 years ago
scrawl fc5176dc38 Refactor cmake scripts, reducing the amount of find_package(Qt4) 10 years ago
Rohit Nirmal 997347b01e Silence -Wreorder warnings. 10 years ago
dteviot 2ef7fc4e2c Installer work for Windows (Fixes #1621)
1. Correctly reads Windows registry for vanilla MW install location.
2. Populates existing installation page with location of vanilla, when found.
3. On Windows, installer wizard now gets to Import page.
10 years ago
scrawl e0d0997409 Rename omwlauncher -> openmw-launcher, mwiniimport -> openmw-iniimporter 10 years ago
scrawl 697ab16ec5 Fix for coverity defects 10 years ago
dteviot 05b89be8bf Launcher sets content list to match values in openmw.cfg (Fixes #811)
I took the liberty to add accessor & mutator functions for classes ContentListsGameSettings and LauncherSettings , as existing code can reverse order of entries.
Also replaced some "magic strings" with named constants.
10 years ago
Bret Curtis dcfadeb51a fix typo and annoying gcc/clang unused return values in crash catcher 10 years ago
Marc Zinnschlag e755f692cc silenced some annoying warnings 10 years ago
Marc Zinnschlag 003675318d Merge remote-tracking branch 'scrawl/master' 10 years ago
scrawl ff8bdd74ed Fix strange bitflags handling 10 years ago
cc9cii 69134e3ac2 Add icon to windows executable. 10 years ago
scrawl 4bf5c89e6f Merge branch 'master' of https://github.com/OpenMW/openmw into unshield
Conflicts:
	apps/wizard/CMakeLists.txt
10 years ago
scrawl abf49267ea Unshield include fix 10 years ago
scrawl a8a2b44b0f Don't require libunshield on windows 10 years ago
Nikolay Kasyanov a0c454b01c Properly add libunshiled include dir (again, for wizard this time) 10 years ago
scrawl 1e06f69d9e Remove the "browse to existing installation" button, now replaced by the wizard
Clean up some debug spam
10 years ago
pvdk 6348af586e Fixed some problems with the launcher and the wizard 11 years ago
pvdk a390dde818 Fixed importing configurations of existing installations 11 years ago
pvdk 2a6a26c0d0 Minor fixes 11 years ago
pvdk 88064f4946 Fix for MOC error due to Boost includes 11 years ago
pvdk aa07a33906 Fixed most of the memory leaks and started working on correctly exiting the thread 11 years ago
pvdk 5d94cb112f Fixed segfault bug due to accessing members of unitialized struct 11 years ago
pvdk 6ed76858d9 Fixed some minor problems with the wizard 11 years ago
pvdk f8bb797b8a Settings tab is fully functional now 11 years ago
pvdk 21c406316f Working on the Settings tab: start the importer/wizard 11 years ago
pvdk 14b164a03d Reverted an unneeded fix 11 years ago
pvdk 10d2ca82f7 Implemented a simple logger 11 years ago
pvdk eb04fa85b7 Added background image to the last page too 11 years ago
pvdk ef617fdf3d Fail on the first error whilst extracting an archive 11 years ago
pvdk 667b0de250 Fixed problems with cd content autodetection 11 years ago
pvdk 2e1248537e Minor fixes, installation should stop after one error message now 11 years ago
pvdk 9e5e19f9cb Improved existing installation handling 11 years ago
pvdk ae5f783a16 Added some eye-candy to the wizard: a watermark and a placeholder icon 11 years ago
pvdk 254fe0a424 Made install functions use file finding methods and improved error handling 11 years ago
pvdk ef16b46148 Wizard now autodetects correct installation archive 11 years ago
pvdk b2156351d8 Work in progress commit, working on data1.hdr autodetection 11 years ago
pvdk 05f8af0757 Use the correct encoding for the ini importer 11 years ago
pvdk 6b9082c6ba Support different Tribunal patch .esm location, as seen on German GoTY disk 11 years ago
pvdk d30c4edb14 Support separate Splash directory, found in some installation media cabinets 11 years ago
pvdk 3792b301e9 Wizard now runs the ini-importer to import settings from Morrowind.ini 11 years ago
pvdk 36d4287da4 Fixed openmw.cfg handling: file should not be cleared anymore 11 years ago
pvdk 755c99df3c Some minor fixes 11 years ago
pvdk 6916c0bc94 Wizard now writes valid Morrowind.ini files 11 years ago
pvdk e8170adde5 Some minor changes, implemented suggestions 11 years ago
pvdk ceb66d0790 Also install the separate Sounds directory for Tribunal 11 years ago