Commit Graph

108 Commits (0d9b1a579522fa96c3257bc8df364387c7b1a743)

Author SHA1 Message Date
AnyOldName3 28131fd62b Fixes for a whole bunch of warnings
These warnings were always enabled, but we didn't see them due to https://gitlab.com/OpenMW/openmw/-/issues/7882.
I do not fully understand the cause of 7822 as I can't repro it in a minimal CMake project.

Some of these fixes are thought through.
Some are sensible best guesses.
Some are kind of a stab in the dark as I don't know whether there was a
possible bug the warning was telling me about that I've done nothing to
help by introducing a static_cast.

Nearly all of these warnings were about some kind of narrowing
conversion, so I'm not sure why they weren't firing with GCC and Clang,
which have -Wall -Wextra -pedantic set, which should imply -Wnarrowing,
and they can't have been affected by 7882.

There were also some warnings being triggered from Boost code.
The vast majority of library headers that do questionable things weren't
firing warnings off, but for some reason, /external:I wasn't putting
these Boost headers into external mode.

We need these warnings dealt with one way or another so we can switch
the default Windows CI from MSBuild (which doesn't do ccache) to Ninja
(which does).
I have the necessary magic for that on a branch, but the branch won't
build because of these warnings.
10 months ago
Andrei Kortunov 5dcac4c48f Do not treat Alt-Tab as resolution change (bug 7866) 10 months ago
elsid dcd81d026f
Use settings values for Video settings
* Convert window mode, vsync mode into enums, screenshot type into a struct.
* Add missing doc for screenshot type.
1 year ago
Zackhasacat 349bad4f98 Remove special handling for Mac command key, since MyGUI now switches automatically 1 year ago
Andrei Kortunov 35561450f1 Do not copy osg::ref_ptr when possible 1 year ago
Evil Eye 5491512905 Use string_view in more places and reduce the number of empty string literals 2 years ago
jvoisin c7a3f43915 Minor header cleanup
This has been done via CLion's "unused include directive",
set to "detect completely unused".
2 years ago
Andrei Kortunov be488649c3 Add support for non-adaptive VSync (feature 7129) 2 years ago
clang-format-bot ddb0522bbf
Apply clang-format to code base 2 years ago
unrelentingtech 1c8fd2ecdb Implement system-scaled HiDPI support (SDL_WINDOW_ALLOW_HIGHDPI - Wayland, macOS, etc) 2 years ago
Andrei Kortunov a2c02d2999 Support high-resolution cursor textures (feature 6933) 2 years ago
Andrei Kortunov e3ad30a517 Do not copy data when it is not needed 2 years ago
psi29a b551e69b6f #5534 remove OSG 3.4 support and require at least 3.6.5 support 2 years ago
psi29a 04fcfcc79d Merge branch 'master' into 'bigpeepeventsenergy'
# Conflicts:
#   components/sdlutil/sdlinputwrapper.cpp
2 years ago
Alexei Kotov f9fdcfe4a7 Prevent mouse movement events from being queued in loading screens (bug #4374) 2 years ago
Alexei Kotov bb2fa1cbfa Break SDL_PeepEvents loop on error (bug #6890) 2 years ago
cody glassman ad139f2f9a rename to windowed fullscreen 3 years ago
cody glassman 05901a2480 add borderless windows, deprecate fullscreen mode 3 years ago
uramer cc6dce5443 Support controller touchpads (Resolves https://gitlab.com/OpenMW/openmw/-/issues/6639) 3 years ago
uramer 15c7bddd57 Move SDL-MyGUI input mappings to components, map both ways 3 years ago
psi29a 56939b478e Merge branch 'windowing-system-cleanup' into 'master'
sdlcursormanager: Clarify ANDROID check

See merge request OpenMW/openmw!556
3 years ago
Andrei Kortunov e38063dcdb Discard button press events during save loading (bug #5619) 4 years ago
Andrei Kortunov 987b231fdd Fix an another portion of Coverity warnings 4 years ago
Andrei Kortunov ac347810ca Fix uninitialized field in the mouse event 4 years ago
Andrei Kortunov 124a33d8a3 Fix uninitialized variables 4 years ago
Gleb Mazovetskiy 044e784072 gl4es: Delay feature detection until a context exists
gl4es feature detection does not work reliably with EGL.

If a context already exists, gl4es can instead reliably detect
the underlying GLES features from the context itself.

This requires gl4es to be configured with:

    -DNOEGL=ON -DNO_LOADER=ON -DNO_INIT_CONSTRUCTOR=ON

This also requires gl4es to have this fix: https://github.com/ptitSeb/gl4es/pull/271
4 years ago
Gleb Mazovetskiy 7fe39c6a3a sdlcursormanager: Clarify ANDROID check
This check will not be needed in the upcoming versions of OSG.

This was originally needed due to a bug in OSG that was fixed in
https://github.com/openscenegraph/OpenSceneGraph/pull/1027
4 years ago
Gleb Mazovetskiy cd5e31dc4b Revert "Merge branch 'windowing-system' into 'master'"
This reverts merge request !541
4 years ago
Gleb Mazovetskiy d24a5f7b89 Fix OSG USE_GRAPHICSWINDOW check
When OSG is built with `-DOSG_WINDOWING_SYSTEM=None`, this macro does not exist.

Replaces the Android-specific check with a general one.
4 years ago
Andrei Kortunov 8084a336b5 Replace zeroes and nulls by nullptrs 4 years ago
Andrei Kortunov 8ca3c3b123 Mark overrided methods by override keyword 4 years ago
psi29a 22c3588d0d Merge branch '4771-and-4631' into 'master'
Try lower MSAA level if the requested value isn't available

Closes #4471 and #4631

See merge request OpenMW/openmw!297

(cherry picked from commit b3db387512340a5e9a77427c2d7d9d88c2340056)

da0aef7a Retrieve SDL OpenGL attributes after context creation
a51e63b3 Try lower MSAA levels if OpenGL context doesn't have what we requested
c4e92a0a Update CHANGELOG.md
4 years ago
Capostrophic a211527b4b Fix AppVeyor warnings 4 years ago
Mads Buvik Sandvei 90c3089370 Update sdlvideowrapper.cpp 5 years ago
Mads Buvik Sandvei 8323f7f68d Alternative fix 5 years ago
Mads Buvik Sandvei 8aa57a745a Fix 5 years ago
Andrei Kortunov b33c4c920c Move all OICS handling to the separate file 5 years ago
Andrei Kortunov f990150c49 Move video wrapper to the WindowsManager 5 years ago
Andrei Kortunov e63325ebff Support for camera rotation via gyroscope on Android (feature #5311) 5 years ago
elsid b07a6afa91
Avoid virtual call in GraphicsWindowSDL2 ctor
/home/elsid/dev/openmw/components/sdlutil/sdlgraphicswindow.cpp:23:8: warning: Call to virtual function during construction [clang-analyzer-optin.cplusplus.VirtualCall]
    if(valid())
       ^
/home/elsid/dev/openmw/components/sdlutil/sdlgraphicswindow.cpp:23:8: note: This constructor of an object of type 'GraphicsWindowSDL2' has not returned when the virtual method was called
/home/elsid/dev/openmw/components/sdlutil/sdlgraphicswindow.cpp:23:8: note: Call to virtual function during construction
5 years ago
Michael Stopa e4bec88a68 Implement mouse wheel bindings (bug #2679) 5 years ago
terrabyte25 b29476de58
Add support for OpenGLES 3.2 6 years ago
Capostrophic 9b65f0dbca Vsync tweaks
Try to use adaptive vsync if available
Don't use vsync if unavailable
6 years ago
Andrei Kortunov 3032b177a1 Remove redundant includes 6 years ago
Andrei Kortunov 18a59df050 Throw exceptions by value instead of reference 6 years ago
Andrei Kortunov e06f0b797a Replace all NULLs to nullptr 6 years ago
Andrei Kortunov 1452684d9e Use new logging system for components 6 years ago
Nikolay Kasyanov 75d79e98b9 Force software decompression if OPENMW_DECOMPRESS_TEXTURES is set 7 years ago
Nikolay Kasyanov 359f87ab9f Change imageToSurface to return a unique_ptr to avoid manual surface cleanup 7 years ago
Nikolay Kasyanov 224b94c0ce Decompress cursors using SDL software renderer on Mac or if OSG >= 3.5.8 7 years ago