14dd11372f
Utility functions for little-endian <-> big-endian conversion.
4 years ago
8b7f3fe908
Merge branch 'nodeadlock' into 'master'
...
Avoid a rare but possible deadlock around mCollisionWorldMutex.
See merge request OpenMW/openmw!525
4 years ago
b3f3b29bbe
Merge pull request #3039 from akortunov/screenshotmanager
...
Move screenshots handling to the separate class
4 years ago
a735bbe9a5
Merge pull request #3040 from akortunov/pvs
...
Fix some issues, found by PVS Studio
4 years ago
e737bd00fa
Merge branch 'unused_param' into 'master'
...
Remove never used parameter from CharacterController::update()
See merge request OpenMW/openmw!523
4 years ago
c3a952c133
Merge branch 'dorsbien' into 'master'
...
Don't update magic effects when unequipping items to equip something else
Closes #5687
See merge request OpenMW/openmw!509
4 years ago
a257567b80
Don't update magic effects when unequipping items to equip something else
4 years ago
ef852b2c8f
Merge branch 'fix_ubsan_issues' into 'master'
...
Fix UBSAN issues
See merge request OpenMW/openmw!528
4 years ago
d2d8a7a940
Fix passing null to memcpy
...
/home/elsid/dev/openmw/components/detournavigator/navmeshtilescache.cpp:36:24: runtime error: null pointer passed as argument 2, which is declared to never be null
#0 0x55e37ba4cda5 in makeNavMeshKey /home/elsid/dev/openmw/components/detournavigator/navmeshtilescache.cpp:36
#1 0x55e37ba4cda5 in DetourNavigator::NavMeshTilesCache::set(osg::Vec3f const&, osg::Vec2i const&, DetourNavigator::RecastMesh const&, std::vector<DetourNavigator::OffMeshConnection, std::allocator<DetourNavigator::OffMeshConnection> > const&, DetourNavigator::NavMeshData&&) /home/elsid/dev/openmw/components/detournavigator/navmeshtilescache.cpp:81
#2 0x55e37fe3c861 in DetourNavigator::updateNavMesh(osg::Vec3f const&, DetourNavigator::RecastMesh const*, osg::Vec2i const&, osg::Vec2i const&, std::vector<DetourNavigator::OffMeshConnection, std::allocator<DetourNavigator::OffMeshConnection> > const&, DetourNavigator::Settings const&, std::shared_ptr<Misc::ScopeGuarded<DetourNavigator::NavMeshCacheItem> > const&, DetourNavigator::NavMeshTilesCache&) /home/elsid/dev/openmw/components/detournavigator/makenavmesh.cpp:582
#3 0x55e37fb796ce in DetourNavigator::AsyncNavMeshUpdater::processJob(DetourNavigator::AsyncNavMeshUpdater::Job const&) /home/elsid/dev/openmw/components/detournavigator/asyncnavmeshupdater.cpp:178
#4 0x55e37fb9a125 in DetourNavigator::AsyncNavMeshUpdater::process() /home/elsid/dev/openmw/components/detournavigator/asyncnavmeshupdater.cpp:144
#5 0x7f013f585c23 in execute_native_thread_routine /build/gcc/src/gcc/libstdc++-v3/src/c++11/thread.cc:80
#6 0x7f013f8c63e8 in start_thread (/usr/lib/libpthread.so.0+0x93e8)
#7 0x7f013e91d292 in __GI___clone (/usr/lib/libc.so.6+0x100292)
4 years ago
7b54415c40
Fix reference binding to null
...
/usr/include/c++/10.2.0/bits/stl_vector.h:1046:34: runtime error: reference binding to null pointer of type 'value_type'
#0 0x55e37f50008a in std::vector<char, std::allocator<char> >::operator[](unsigned long) /usr/include/c++/10.2.0/bits/stl_vector.h:1046
#1 0x55e37f50008a in ESM::SavedGame::load(ESM::ESMReader&) /home/elsid/dev/openmw/components/esm/savedgame.cpp:28
#2 0x55e37e726139 in MWState::Character::addSlot(boost::filesystem::path const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/elsid/dev/openmw/apps/openmw/mwstate/character.cpp:31
#3 0x55e37e742b39 in MWState::Character::Character(boost::filesystem::path const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/elsid/dev/openmw/apps/openmw/mwstate/character.cpp:88
#4 0x55e37e7006e1 in MWState::CharacterManager::CharacterManager(boost::filesystem::path const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/elsid/dev/openmw/apps/openmw/mwstate/charactermanager.cpp:25
#5 0x55e37e6d4140 in MWState::StateManager::StateManager(boost::filesystem::path const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/elsid/dev/openmw/apps/openmw/mwstate/statemanagerimp.cpp:90
#6 0x55e37e82595a in OMW::Engine::prepareEngine(Settings::Manager&) /home/elsid/dev/openmw/apps/openmw/engine.cpp:641
#7 0x55e37e8439fd in OMW::Engine::go() /home/elsid/dev/openmw/apps/openmw/engine.cpp:867
#8 0x55e37e782760 in runApplication(int, char**) /home/elsid/dev/openmw/apps/openmw/main.cpp:289
#9 0x55e37f6483c3 in wrapApplication(int (*)(int, char**), int, char**, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/elsid/dev/openmw/components/debug/debugging.cpp:200
#10 0x55e37ba8e3fe in main /home/elsid/dev/openmw/apps/openmw/main.cpp:301
#11 0x7f013e845151 in __libc_start_main (/usr/lib/libc.so.6+0x28151)
#12 0x55e37baa0e3d in _start (/home/elsid/dev/openmw/build/gcc/ubsan/openmw+0x6c11e3d)
4 years ago
f7d7186c39
Merge branch 'instanceselectiontools' into 'master'
...
[OpenMW-CS] Cube and sphere instance selection
See merge request OpenMW/openmw!485
4 years ago
313e895912
[OpenMW-CS] Cube and sphere instance selection
4 years ago
60f66f5e29
Remove never used parameter from CharacterController:update()
4 years ago
9bc687e209
Avoid a rare but possible deadlock around mCollisionWorldMutex.
...
What happened is that the last handle to an Actor shared_ptr was a
promoted weak_ptr. When the shared_ptr goes out of scope, the Actor dtor
is invoked. That involves removing the Actor collision object after
exclusively locking mCollisionWorldMutex. In this case, the lock was
already held in the outter scope of the promoted weak_ptr.
Reduce the scope of the mCollisionWorldMutex to never encompass the
lifetime of a promoted weak_ptr.
4 years ago
ad101de733
Merge declaration and initialization
4 years ago
1930f8f37d
Fix copy-paste error
4 years ago
50e4600b16
Reduce code duplication
4 years ago
4fcf3b80b1
Merge branch 'madsbuvi-master-patch-13347' into 'master'
...
engine.cpp typos
See merge request OpenMW/openmw!521
4 years ago
874348fb46
Remove redundant code
4 years ago
a2d8a0b61a
engine.cpp typos
4 years ago
80ee1b55ea
Protect assignment operator from this == &src case
4 years ago
33da0af1d1
Use explicit calls for virtual methods in constructors
4 years ago
a80ee7a76a
Avoid possible memory leak in the mInterMessageBoxe field
4 years ago
8e5f26c109
Code cleanup
4 years ago
c9b885ffd4
Avoid possible null dereferencing
4 years ago
33648313a6
Initialize variables
4 years ago
c1512b8b6c
Convert loop to condition
4 years ago
56666c60d4
Remove dead code
4 years ago
8283ec6cad
Do not use & for boolean arguments
4 years ago
7fc4c9f3f6
Avoid dead code
4 years ago
801e2d6ad0
Avoid to use uninitialized variables
4 years ago
c5a36ad440
Do not cast enums to booleans
4 years ago
799bd3379c
Move screenshots handling to the separate class
4 years ago
2d61db555b
Merge branch 'osg_log' into 'master'
...
Split long osg log messages into lines.
See merge request OpenMW/openmw!519
4 years ago
7d551b0cfd
Split long osg log messages into lines.
4 years ago
cbce3ebb79
Merge branch 'stanky_fetcher' into 'master'
...
Consider a path completed if it was non-empty
Closes #5773
See merge request OpenMW/openmw!508
4 years ago
2a583e2337
consider empty paths as not constructed
4 years ago
dc82cb61f4
Merge branch 'nativeshapesdebug' into 'master'
...
Unbreak physics debugger with projectiles' spherical shapes.
See merge request OpenMW/openmw!489
4 years ago
bbd11cb14e
Merge branch 'changelog' into 'master'
...
Remove #5683 changelog entry
See merge request OpenMW/openmw!514
4 years ago
701a5662b0
Remove #5683 changelog entry
4 years ago
c17e498465
Merge branch 'launchercleanup' into 'master'
...
Remove deadcode from the launcher.
See merge request OpenMW/openmw!511
4 years ago
5215ffd964
The debug drawer rely on Bullet to determines the vertices of collision
...
shapes. It doesn't work in the case of spheres (used by projectiles):
resulting shape is malformed. It can also leads to this error which
makes the debug drawer non-working till game restart:
CullVisitor::apply(Geode&) detected NaN,
depth=nan, center=(nan nan nan),
matrix={
-0.265814 -0.0639702 0.9619 0
0.964024 -0.0176387 0.265228 0
-4.29769e-09 0.997796 0.0663574 0
18178.6 -3550.91 42154.4 1
}
Avoid this issue by using osg::Sphere
While here, remove an unused function. We don't use Bullet's solver so
we never have any contact points (in Bullet parlance).
4 years ago
dbdd397716
Remove deadcode.
4 years ago
57c92673bc
Consider a path completed if it was non-empty
4 years ago
cdf0bc1d8d
Merge branch 'protec' into 'master'
...
Switch torches to shields for hostile NPCs
Closes #5300
See merge request OpenMW/openmw!501
4 years ago
e46472442a
Switch torches to shields for hostile NPCs
4 years ago
8c37817cf1
Merge branch 'viewingdistance' into 'master'
...
Make min and max view distance accurate to vanilla
See merge request OpenMW/openmw!504
4 years ago
e4e19bab1b
Make min and max view distance accurate to vanilla
4 years ago
66e0a7ff02
Merge pull request #3038 from akortunov/master
...
Fix defines names
4 years ago
1c6c86a113
Merge branch 'changelog' into 'master'
...
Fixed by 7cac7fa870Closes #4039
See merge request OpenMW/openmw!502
4 years ago
Petr Mikheev
elsid
Bret Curtis
Evil Eye
Alexei Dobrohotov
Nelsson Huotari
fredzio
Andrei Kortunov
AnyOldName3
Mads Buvik Sandvei
Alexei Dobrohotov