Commit Graph

409 Commits (1f2349ef6e82b7b1b82e1de6db2776e2043fb18d)

Author SHA1 Message Date
scrawl 29556a1802 More consistent wording of errors/warnings
A Warning indicates a potential problem in the content file(s) that the user told OpenMW to load. E.g. this might cause an object to not display at all or as intended, however the rest of the game will run fine.

An Error, however, is more likely to be a bug with the engine itself - it means that basic assumptions have been violated and the engine might not run correctly anymore.

The above mostly applies to errors/warnings during game-play; startup issues are handled differently: when a file is completely invalid/corrupted to the point that the engine can not start, that might cause messages that are worded as Error due to the severity of the issue but are not necessarily the engine's fault.

Hopefully, being a little more consistent here will alleviate confusion among users as to when a log message should be reported and to whom.
8 years ago
scrawl 1692b7f38e Merge pull request #1209 from dhustkoder/master
Added ConstContainerStoreIterator (Task #3092)
8 years ago
Rafael Moura 7fa2703715 Porting more ContainerStoreIterator usage to const version #3 8 years ago
Rafael Moura 18a4b64f1a Porting more ContainerStoreIterator usage to const version #2 8 years ago
scrawl 3f27c8cc97 Always print context for script warnings to remove the need for verbose option
(Fixes #2813)
8 years ago
Allofich 5e992a0342 Fix attempting to access NPC stats on creatures 8 years ago
MiroslavR 5f234f8952 Dialogue: "PC Rank" condition now uses speaker's faction if "PC Faction" is not given (Fixes #3689) 8 years ago
Leon Krieg c7b4b2cdd7 Fixed multiple spelling mistakes 8 years ago
Allofich 1c54f54ab8 Fix shadowing warnings 8 years ago
Allofich 1c2e04747d Remove stray line 8 years ago
MiroslavR 14468262a7 Fix "Not Local" dialog test to also test variable value instead of just its existence (Fixes #3577) 8 years ago
Allofich 028db21c8a Don't let disposition at end of dialogue be below 0 (Fixes #3584) 8 years ago
Allofich 53e94b7c3f Fix shadowing warnings 8 years ago
scrawl b6230bd31f Reject weather dialogue conditions when in an interior cell (Fixes #3437) 9 years ago
scrawl 2ca7415708 Handle DialInfo::mFactionLess (Bug #3380) 9 years ago
scrawl 4854d6b093 Set the TalkedToPc flag for voiced dialogue (Fixes #3346) 9 years ago
scrawl 79eb2d20e0 Cleanup 9 years ago
scrawl 12ec90f9e7 Change default argument, fix GetDisposition 9 years ago
ae-g-i-s c9791c5c1a Add addTemporaryDispositionChange parameter to MechanicsManager::getDerivedDisposition(), adjust callers that previously added temp disposition changes themselves (fixes #3233) 9 years ago
ae-g-i-s 2f1c6c740c Revert "Fix incorrect handling of baseDisposition >= 100 in testDisposition(), enable unbounded getDerivedDisposition() (Fixes #3233)"
This reverts commit 000597236e.
9 years ago
ae-g-i-s 000597236e Fix incorrect handling of baseDisposition >= 100 in testDisposition(), enable unbounded getDerivedDisposition() (Fixes #3233) 9 years ago
scrawl 90a99991d1 Use empty() instead of !size() 9 years ago
scrawl f315a4386f Accept an implicit reference in Journal (Fixes #3135) 9 years ago
scrawl a9f0f30bb8 Reject conditions testing agaist Choice when not currently in a choice (Fixes #3117) 9 years ago
scrawl 0333c40047 Fix typo in SameRace dialogue function (function was inverted, Fixes #3116) 9 years ago
scrawl 2176ac592c Call updateDialogueGlobals before dialogue starts (Fixes #3034) 9 years ago
scrawl 04f7a8f8eb Remove redundant getId function 9 years ago
scrawl 8222c78cf2 Do not filter creature dialogue by NPC-only conditions (Fixes #3086) 9 years ago
scrawl 2737aabe93 Pc functions apply to creature dialogue (Fixes #3078) 9 years ago
scrawl f875597be5 Don't use tolower()
See https://forum.openmw.org/viewtopic.php?f=8&t=3231&p=35968
9 years ago
scrawl c912310c52 Don't add persuasion results to the journal 9 years ago
scrawl d5a738bd39 Apply 27e669296e (locale-unaware tolower) to more code
In particular, the one in VFS::normalizeFilename was affecting cell loading performance.
9 years ago
scrawl 93565eccbf Update the dialogue topic list after running greeting script 9 years ago
scrawl 04df656f54 Remove some junk 9 years ago
dteviot 77a1d947cc extracted MWMechanics::getPlayer() 10 years ago
scrawl 67bd6cd708 Remove empty line at the beginning of files
git ls-files -z | xargs -0 sed -i '1{/^$/d}'
10 years ago
scrawl 24ae1d5ace Fix some issues found by coverity 10 years ago
Alexander "Ace" Olofsson 3655ef16af Explicitly instantiate ESM::StatState 10 years ago
scrawl 141e9d36a4 Get rid of unused DialogueManager::mScriptVerbose 10 years ago
Rohit Nirmal 396fba7fa9 Silence -Wreorder warnings, and remove -Wno-reorder. 10 years ago
scrawl ac88326909 Exit out of choice when no responses are found (Fixes #2525) 10 years ago
scrawl 37a6d7da76 WindowManager refactoring 10 years ago
scrawl e30f240ba2 Add travel service support for creatures (Fixes #2432) 10 years ago
dteviot e197f5318b fixing MSVC 2013 warning C4244: & C4305
conversion from 'const float' to 'int', possible loss of data
conversion from 'double' to 'int', possible loss of data
conversion from 'float' to 'int', possible loss of data
10 years ago
Alexander "Ace" Olofsson df5a08b6de Move manualref code out of header 10 years ago
scrawl 0c6e2170db Include cleanup 10 years ago
Marc Zinnschlag c02c72e134 Merge remote-tracking branch 'jordan-ayers/topic/dialogue-set' 10 years ago
Jordan Ayers 419046e121 Dialogue: Use std::set for known topics in the manager.
There were three different data structures being used for topic lists
in this code.  (map< string, true >, list< string >, and vector< string >)
Switch the local topic lists to set< string >.  This supports everything
the list and map were doing, reduces the variety of data structures, and
makes count (a more efficient search) available.

The vector has not changed, since it's tied to the ESM modules, and must
meet other requirements.
10 years ago
scrawl 431f540791 ESSImport: fix NPC factions 10 years ago
scrawl 6367b4dc0b Improve INFO struct naming 10 years ago
scrawl 6f41e0d12e Reapply quest index when loading quest from savegame (Bug #2260) 10 years ago
scrawl 697ab16ec5 Fix for coverity defects 10 years ago
scrawl c883a73d30 Several warning fixes 10 years ago
scrawl 8b5effe3e0 Fix wrong magic number for JOUR in openmw savegames 10 years ago
scrawl 5104a5a023 Add missing setFactionReaction instruction, use absolute storage instead of difference
Seems to be closer to how MW is storing it (it has the complete FACT record in the savegame, actually).

This (somewhat) breaks OMW savegame compatibility in that old changes are discarded, but I don't think the faction reactions are quest relevant anywhere.
10 years ago
scrawl c3f3f8b3d0 Use only Cell records for saving progress bar (Fixes #2259) 10 years ago
scrawl 579f5d232f Move interactive messageBox to separate function 10 years ago
scrawl 37bea9d4dc Fix exception for empty dialog topics (Fixes #2267) 10 years ago
scrawl ce2cbab402 Dialogue: improve conflict resolution for chains of overlapping keywords (unit test for such a case will follow) 10 years ago
scrawl ddd6e682bc Dialogue: add conflict resolution for overlapping keywords (Fixes #2245) 10 years ago
scrawl cc9af9562b Function_CreatureTargetted should return '2' for werewolfs
This makes NPCs say the correct attack voice files when fighting a werewolf.
10 years ago
scrawl 4aed5158cc Support region names in cell dialogue filter (Fixes #2113) 10 years ago
Marc Zinnschlag a6d30bc2e3 consider --script-warn when running with --script-all-dialogue 10 years ago
Marc Zinnschlag 1f74d8cca5 Merge remote-tracking branch 'scrawl/scripttest' 10 years ago
scrawl ba65c6cc7f Add --script-all-dialogue switch to compile all dialogue scripts (Fixes #1659) 10 years ago
scrawl 2ebf328dec Always print the failing dialogue script
These aren't usually very long, so printing them shouldn't spam the console by too much.
10 years ago
MiroslavR 5a7dbb19f7 Code clarity 10 years ago
MiroslavR ed6bdc0bde Use all topics to search for keywords in dialogues (Fixes #2013)
Move KeywordSearch to MWDialogue
Move hypertext parsing functions to a new file
10 years ago
scrawl c4fa671381 Don't allow raising faction rank if the next rank has no name (Fixes #1975) 10 years ago
scrawl 7252cb63a6 Fix cppcheck issues 10 years ago
scrawl e54ba2c5d1 Fix broken dialogue Function_HealthPercent 10 years ago
scrawl d8943aef2f Encapsulate magic effect magnitude (Feature #1489) 11 years ago
scrawl e508450c1c Add persuasion GMST to ensureNeededRecords (Fixes #1817) 11 years ago
Marc Zinnschlag c9cd7fb6b7 Merge branch 'scripts' 11 years ago
Marc Zinnschlag f6b502b195 rewrote dialgoue filter access to local variables 11 years ago
scrawl d4ffd30f98 Implement Rank filter with no faction given (Fixes #1660) 11 years ago
scrawl f9a39138cc Add missing endline 11 years ago
scrawl 8b404ee255 Fix not being able to exit dialogue using Escape when a Goodbye link appears 11 years ago
scrawl 28feb260eb Implement disposition/distance based aggression (Fixes #1520) 11 years ago
scrawl 0aba1088a1 Attempt to open companion window if no greetings are found (Bug #1507) 11 years ago
scrawl 1adb81abd0 Sort using ciLess, not ciEqual 11 years ago
scrawl 88f8f25ffa Don't allow scripted dialogue with dead actors (Fixes #1493) 11 years ago
scrawl 2dd54dbcfc Implement ClearInfoActor script instruction (Fixes #1422) 11 years ago
scrawl a90245147b Don't reset history when ForceGreeting is used and a dialogue window was already open for the same actor (Fixes #1423) 11 years ago
scrawl 1ed3f092c1 Implement text replacement for journal topic responses (Fixes #1429) 11 years ago
scrawl 865486604f Make trade disposition changes temporary again, as in vanilla 11 years ago
scrawl 0b45a9e6b2 Fix case folding for faction reaction from ESX records 11 years ago
scrawl e266c39c5d Implement modFactionReaction instruction (Closes #1347) 11 years ago
scrawl b47b2b84f3 Merge branch 'master' of https://github.com/OpenMW/openmw
Conflicts:
	apps/openmw/mwdialogue/filter.cpp
	apps/openmw/mwgui/waitdialog.cpp
11 years ago
scrawl df8e095c83 Small cleanup 11 years ago
Emanuel Guevel 1e4a854433 Remove static method MWWorld::Class::get(&Ptr)
It was just adding a level of indirection to Ptr.getClass().
All the call were replaced by that instead. The number of lines changed
is important, but the change itself is trivial, so everything should be
fine. :)
11 years ago
scrawl 3380e1e1c5 Fix ShouldAttack filter
This makes NPCs exit dialogue properly when they should attack as a result of taunting actions.
11 years ago
scrawl 1677fcf324 Dialogue merging 11 years ago
scrawl 5fc2b1a41b Allow setting a journal index even if there's no related journal entry
This is used by the MV_SlaveMule quest.
11 years ago
scrawl e1458453f3 Fix "unknown info ID" exceptions when a dialogue response is from the Info Refusal group
Could be observed in TG_OverduePayments quest when talking to Trasteve about Dwemer Artifacts.

Info Refusal responses are not specific to any particular topic, so they should not be added to the journal. Trying to do so anyway will cause "unknown id" exceptions because MWDialogue::Entry expects the infoId to be from the Dialogue for the supplied topic.
11 years ago
scrawl 872d9be1b4 Fix potential issue with dialogue globals
Make sure they are updated throughout the conversation
11 years ago
scrawl 27a05027f4 Fixes #1172: Added basic loading/saving progress bar
The progress is not particularly accurate. It simply uses the current / total number of records written/read as indication. Cell records are currently the largest by far, but there is a good chance that could be optimized using a change tracking system.
11 years ago
scrawl f921f2e7db Make PcRaiseRank, PcLowerRank and PcJoinFaction properly accept references instead of using the actor that the player talked to last.
This also solves a potential crash when no actor has been talked to yet, e.g. immediately after loading a savegame.
11 years ago
scrawl b13b25dd1b Fixes #1295: Support partial matches in Cell filter 11 years ago
scrawl 5eeed03f5b Only exchange bribe gold if the bribe was accepted 11 years ago