Commit Graph

240 Commits (master)

Author SHA1 Message Date
elsid 843753da14
Remove unused includes 2 years ago
elsid 063fff7fa4
Fix and prevent -Wextra-semi warning 2 years ago
clang-format-bot ddb0522bbf
Apply clang-format to code base 2 years ago
elsid 6f00641c8a
Fix reading array of zero terminated strings
NIFZ and KFFZ subrecords store multiple strings separated by \0 character.
2 years ago
elsid 4f7dcd5ae5
Fix conversion to UTF8 for ESM4 Reader strings
toUtf8 returns a string view to the input when input string is ASCII and nothing
is written to the buffer which means output string of Reader::getStringImpl is
not modified.

Move input to the output string and resize it in this case.
2 years ago
Project579 886b8c7af2 Fix build error with stdlibc++ due to includes shuffling. 2 years ago
Project579 a13709c510 Replace implicit convertions from std::filesystem::path to std::string with correctly converting functions. 2 years ago
Project579 e5c417c968 Make sure all paths are passed as std::filesystem::path instead of std::string where possible. 2 years ago
elsid ac1688f9c1
Remove ESM::Reader base class
This class does not serve any useful purpose now. It was added as a first step
in attempt to define common interface for ESM3 and ESM4 readers. But this is not
going to happen.
2 years ago
florent.teppe 252550d86f Added records for ESM4s the throw std:: logic error ensures at compile time that there is no collision
static_assert doesn't work because the function can be called at run time
2 years ago
AnyOldName3 4e8e2e1c60 Eliminate &thing[0] pattern 2 years ago
elsid f99ed6f1db
Split components/misc/stringops.hpp into multiple headers
Replace all ciEqual overloads with one having std::string_view as argument.
2 years ago
elsid 6c8ed4d19c
Move Files::IStreamPtr alias to a separate header
To avoid transitive include of Windows.h all over the engine.
2 years ago
Andrei Kortunov 14b5674d32 Init missing data members 3 years ago
Andrei Kortunov 523ad825c2 There is no point to compare an unsigned value with 0 3 years ago
jvoisin aeb3733e57 Remove boost:: constructs
Namely boost::scoped_array and boost::to_lower_copy.
3 years ago
jvoisin 4e4debb1cb Remove even more of boost::filesystem 3 years ago
jvoisin 331363d469 Merge branch 'fix_uninit' into 'master'
Fix uninitialized coverity warnings

See merge request OpenMW/openmw!1819
3 years ago
Evil Eye a64979e25d Replace empty std::string assignments 3 years ago
jvoisin 143dcad0e8 Use an `if` instead of an assert 3 years ago
elsid b67a0a8f2b
Fix uninitialized coverity warnings 3 years ago
elsid d2510284ec
Support TES4 in esmtool dump 3 years ago
elsid 4b28d51d5e
Remove virtual modifiers from ESM4 record functions
There is no need to have virtual functions.
3 years ago
elsid 2c9b6fffe5
Remove preloading logic from ESM4::Cell
This logic does not belong here. If client of ESM4::Cell needs to cache load
results it can be done separately.
3 years ago
elsid 13c970b37a
Add const modifier to encoder type 3 years ago
elsid c7ba4100e1
Remove undefined and redundant ESM4 record type constructors 3 years ago
psi29a f99f818c0c Merge branch 'esm4_cleanup' into 'master'
ESM4 cleanup

See merge request OpenMW/openmw!1792
3 years ago
elsid 4a49bc4941
Remove undefined constructor declaration 3 years ago
elsid d71a1efa92
Rename components/esm4/acti.hpp -> components/esm4/loadacti.hpp 3 years ago
elsid d5fb2f8091
Use ESM::fourCC to define ESM4 record types 3 years ago
elsid 3abcf3dd0d
Fix style guide 3 years ago
elsid 94c1d0cced
Use unique_ptr to store istream 3 years ago
elsid 5eb8c4aebe
Avoid redundant conversion to const char* and use make_shared 3 years ago
elsid f516e34688
Remove used-defined constructors from ESM4 types
To avoid explicit initialization. It should happen in the load functions anyway.

* Move all non-zero initializations to corresponding class definition.
* Replace std::vector by std::array when it has constant size.
3 years ago
psi29a 1c1581bdab Merge branch 'check_esm4_compilation' into 'master'
Check ESM4 compilation

See merge request OpenMW/openmw!1677
3 years ago
elsid 96463cbb02
Remove malformed and unused esm4/records.hpp file 3 years ago
elsid cccfb14785
Remove user-defined constructor from ESM4::Quest
To avoid explicit initialization. It should happen in the load functions anyway.
3 years ago
elsid 139ae9325a Fix compile errors by using StatelessUtf8Encoder 3 years ago
Bret Curtis 8113620dce handle a few wearnings raised as errors 3 years ago
cc9cii ba3ae448d4 Initial import of esm4 by cc9cii 3 years ago