1
0
Fork 1
mirror of https://github.com/TES3MP/openmw-tes3mp.git synced 2025-01-16 11:49:56 +00:00
Commit graph

283 commits

Author SHA1 Message Date
Capostrophic
95aa05e41b Tweaks to script parser messages and pathgrid warnings 2018-09-16 16:47:33 +03:00
Capostrophic
5a86554f97 Cleanup 2018-09-14 21:55:50 +03:00
Capostrophic
c025427575 Implement enchantment record effect list verification (feature #1617) 2018-09-14 21:06:50 +03:00
Capostrophic
d6560d3f20 Make several messages more strict and clean up topic info verifier 2018-09-14 21:06:50 +03:00
Capostrophic
5d1c1f25f7 Remove now redundant NPC fields checks 2018-09-14 21:06:50 +03:00
Capostrophic
015cd6064f Implement basic enchantment record verifier (feature #1617) 2018-09-14 21:06:50 +03:00
Capostrophic
dabdb0bfaf Get rid of deprecated Messages::push_back() 2018-09-14 21:06:50 +03:00
Capostrophic
47b9008743 Renovate reference record verifier 2018-09-14 21:06:50 +03:00
Capostrophic
0bdb7ea92f Cleanup 2018-09-14 21:06:50 +03:00
Capostrophic
34ffaa2fe2 Make finishing touches to object record verifiers 2018-09-14 21:06:50 +03:00
Capostrophic
d1b2fc11ef Use messages::add in object record verifiers
Add NPC head and hair body part existence checks and expand creature record verifier, update playable class checks in class record verifier
2018-09-14 21:06:50 +03:00
Capostrophic
85dc1e4ef2 Revert unnecessary universalid changes in Journal record verifier 2018-09-14 21:06:50 +03:00
Capostrophic
e1ae7a9b0e Avoid duplicate duplicate pathgrid point warnings 2018-09-14 21:06:50 +03:00
Capostrophic
1e5330d9da Use Messages::add in skill record verifier 2018-09-14 21:06:50 +03:00
Capostrophic
35281d7c38 Use Messages::add in race, soundgen, spell and start script record verifiers 2018-09-14 21:06:50 +03:00
Capostrophic
b2b9bd94f0 Fix bolt object type 2018-09-14 21:06:50 +03:00
Capostrophic
8dcb58d745 Use Messages::add in Faction, Sound, Bodypart and Class record verifiers 2018-09-14 21:06:50 +03:00
Capostrophic
d433929194 Use Messages::add in birthsign record verifier 2018-09-14 21:06:50 +03:00
Capostrophic
6b226eef8f Use Messages::add in magic effect record verifier 2018-09-14 21:06:50 +03:00
Capostrophic
5b8880c6fa Update cell reference record verifier messages 2018-09-14 21:06:50 +03:00
Capostrophic
dc847dce09 Add item icon checks to object record verifier 2018-09-14 21:06:50 +03:00
Capostrophic
34077a6987 Purge unnecessary namespaces 2018-09-14 21:06:50 +03:00
Capostrophic
d90940011f Add model checks to object record verifier 2018-09-14 21:06:50 +03:00
Capostrophic
38ea7928f5 Add sound file checks to sound record verifier 2018-09-14 21:06:50 +03:00
Capostrophic
1f717def35 Update journal, start script and spell verifiers messages 2018-09-14 21:06:50 +03:00
Capostrophic
a6d3cd9190 Update topic info verifier messages 2018-09-14 21:06:50 +03:00
Capostrophic
14ef145b3b Update region and pathgrid record verifier messages 2018-09-14 21:06:50 +03:00
Capostrophic
a9ce155a7b Update faction and body part record verifier messages 2018-09-14 21:06:50 +03:00
Capostrophic
7535daa94d Update class and race record verifier messages 2018-09-14 21:06:50 +03:00
Capostrophic
fd1a3ad88d Update object and script record verifier messages 2018-09-14 21:06:50 +03:00
Capostrophic
cf7a8c5775 Update soundgen record verifier messages 2018-09-14 21:06:50 +03:00
Capostrophic
5249492a31 Update skill record verifier messages 2018-09-14 21:06:50 +03:00
Capostrophic
51fdb94e34 Add texture check to birthsign verifier 2018-09-14 21:06:50 +03:00
Capostrophic
d3aa5840ec Refactor magic effect record verifying 2018-09-14 21:06:50 +03:00
Andrei Kortunov
6529883527 Fix MSVC warning C4389 2018-09-04 18:14:51 +04:00
Doc West
414f626309 Implemented search case sensitivity 2018-07-04 21:03:54 +02:00
Atahualpa
c0fc615cd6 Adds the option to ignore "Base" records when running the verifier. (fixes #4466)
Improves previous commit:
1. Initialise mIgnoreBase boolean member with FALSE.
2. Remove isBaseOnly() function and replace with direct use of Record member.
2018-06-20 11:29:38 +02:00
Atahualpa
9d61d76e92 Adds the option to ignore "Base" records when running the verifier. (fixes #4466)
Adds a boolean setting to the user preferences. This setting is locally saved to all OpenMW-CS check stages. When a verification is done, the setting is updated on setup for each check stage. If set to true, the boolean value is then used to skip the verification process for every base record - minus some special cases where, e.g., counters are to be set first.

Related issue:
- Fixes #4466: Editor: Add option to ignore base records when running verifier (https://gitlab.com/OpenMW/openmw/issues/4466)

Tests:
The changes were successfully tested in OpenMW-CS by creating faulty "Base" and "Modified" records for every record type (if possible) and, then, running the verifier with and without the option respectively.
2018-06-20 00:20:03 +02:00
Capostrophic
7e38bb8513 Verifier: improve handling of class name and description 2018-05-26 22:37:02 +03:00
Alf Henrik Sauge
feeee50a88 Dropping a separate NPDTstruct12 object and instead use NPDTstruct52
NPDTstruct12 is now only used when loading and saving. Turning auto calc
on and off now no longer switches between to different set of values
2018-05-09 00:25:07 +02:00
Bret Curtis
c44f87afd1
Merge pull request #1699 from Capostrophic/editorwarnings
Editor verifier updates
2018-05-06 10:57:24 +02:00
Bret Curtis
0fc198be52
Merge pull request #1698 from Capostrophic/c++11
A bunch of C++11-related updates
2018-05-06 10:44:11 +02:00
Capostrophic
2502d53816
Object record verifier updates
Removed light 0 duration warning
Spelling fixes
2018-05-06 00:23:05 +03:00
Capostrophic
91b97a27ea
Remove empty class description warning 2018-05-06 00:14:14 +03:00
Capostrophic
e22409c266
Fix sound range warning message 2018-05-06 00:13:09 +03:00
Capostrophic
8be93b4a12
Initialize mandatoryIds vector C++11-way 2018-05-03 19:56:01 +03:00
tri4ng1e
d4d1703bcf
Some PVS-Studio and cppcheck fixes
cppcheck:
[apps/esmtool/record.cpp:697]: (performance) Prefer prefix ++/-- operators for non-primitive types.
[apps/esmtool/record.cpp:1126]: (performance) Prefer prefix ++/-- operators for non-primitive types.
[apps/esmtool/record.cpp:1138]: (performance) Prefer prefix ++/-- operators for non-primitive types.
[apps/niftest/niftest.cpp:36]: (performance) Function parameter 'filename' should be passed by reference.
[apps/niftest/niftest.cpp:41]: (performance) Function parameter 'filename' should be passed by reference.
[apps/opencs/model/prefs/boolsetting.cpp:25]: (warning) Possible leak in public function. The pointer 'mWidget' is not deallocated before it is allocated.
[apps/opencs/model/prefs/shortcuteventhandler.cpp:52]: (warning) Return value of std::remove() ignored. Elements remain in container.
[apps/openmw/mwstate/quicksavemanager.cpp:5]: (performance) Variable 'mSaveName' is assigned in constructor body. Consider performing initialization in initialization list.

PVS-Studio:
apps/opencs/model/filter/parser.cpp  582  warn  V560 A part of conditional expression is always true: allowPredefined.
apps/opencs/view/world/referencecreator.cpp  67  warn  V547 Expression '!errors.empty()' is always false.
apps/opencs/view/world/referencecreator.cpp  74  warn  V547 Expression '!errors.empty()' is always false.
apps/opencs/view/doc/loader.cpp  170  warn  V560 A part of conditional expression is always true: !completed.
apps/opencs/view/doc/loader.cpp  170  warn  V560 A part of conditional expression is always true: !error.empty().
apps/opencs/model/tools/pathgridcheck.cpp  32  err  V517 The use of 'if (A) {...} else if (A) {...}' pattern was detected. There is a probability of logical error presence. Check lines: 32, 34.
apps/opencs/model/world/refidadapterimp.cpp  1376  err  V547 Expression 'subColIndex < 3' is always true.

apps/openmw/mwgui/widgets.hpp  318  warn  V703 It is odd that the 'mEnableRepeat' field in derived class 'MWScrollBar' overwrites field in base class 'ScrollBar'. Check lines: widgets.hpp:318, MyGUI_ScrollBar.h:179.
apps/openmw/mwgui/widgets.hpp  319  warn  V703 It is odd that the 'mRepeatTriggerTime' field in derived class 'MWScrollBar' overwrites field in base class 'ScrollBar'. Check lines: widgets.hpp:319, MyGUI_ScrollBar.h:180.
apps/openmw/mwgui/widgets.hpp  320  warn  V703 It is odd that the 'mRepeatStepTime' field in derived class 'MWScrollBar' overwrites field in base class 'ScrollBar'. Check lines: widgets.hpp:320, MyGUI_ScrollBar.h:181
apps/openmw/mwmechanics/actors.cpp  1425  warn  V547 Expression '!detected' is always true.
apps/openmw/mwmechanics/character.cpp  2155  err  V547 Expression 'mode == 0' is always true.
apps/openmw/mwmechanics/character.cpp  1192  warn  V592 The expression was enclosed by parentheses twice: ((expression)). One pair of parentheses is unnecessary or misprint is present.
apps/openmw/mwmechanics/character.cpp  521  warn  V560 A part of conditional expression is always true: (idle == mIdleState).
apps/openmw/mwmechanics/pathfinding.cpp  317  err  V547 Expression 'mPath.size() >= 2' is always true.
apps/openmw/mwscript/interpretercontext.cpp  409  warn  V560 A part of conditional expression is always false: rank > 9.
apps/openmw/mwgui/windowbase.cpp  28  warn  V560 A part of conditional expression is always true: !visible.
apps/openmw/mwgui/journalwindow.cpp  561  warn  V547 Expression '!mAllQuests' is always false.
apps/openmw/mwgui/referenceinterface.cpp  18  warn  V571 Recurring check. The '!mPtr.isEmpty()' condition was already verified in line 16.
apps/openmw/mwworld/scene.cpp  463  warn  V547 Expression 'adjustPlayerPos' is always true.
apps/openmw/mwworld/worldimp.cpp  409  err  V766 An item with the same key '"sCompanionShare"' has already been added.
apps/openmw/mwworld/cellstore.cpp  691  warn  V519 The 'state.mWaterLevel' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 689, 691.
apps/openmw/mwworld/weather.cpp  1125  warn  V519 The 'mResult.mParticleEffect' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 1123, 1125.
apps/openmw/mwworld/weather.cpp  1137  warn  V519 The 'mResult.mParticleEffect' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 1135, 1137.

apps/wizard/unshield/unshieldworker.cpp  475  warn  V728 An excessive check can be simplified. The '(A && B) || (!A && !B)' expression is equivalent to the 'bool(A) == bool(B)' expression.
apps/wizard/installationpage.cpp  163  warn  V735 Possibly an incorrect HTML. The "</p" closing tag was encountered, while the "</span" tag was expected.

components/fontloader/fontloader.cpp  427  err  V547 Expression 'i == 1' is always true.
components/nifosg/nifloader.cpp  282  warn  V519 The 'created' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 278, 282.
components/esm/loadregn.cpp  119  err  V586 The 'clear' function is called twice for deallocation of the same resource. Check lines: 112, 119.
components/esm/cellref.cpp  178  warn  V581 The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 175, 178.
components/esmterrain/storage.cpp  235  warn  V560 A part of conditional expression is always true: colStart == 0.
components/esmterrain/storage.cpp  237  warn  V560 A part of conditional expression is always true: rowStart == 0.
2018-04-18 12:36:10 +00:00
Kyle Cooley
6d7a24224b Add documentation. 2017-10-16 12:52:13 -04:00
Kyle Cooley
98c38ad7d1 Merge cleanup. 2017-10-14 13:18:31 -04:00
Kyle Cooley
6d9d98c02c Merge Land/LandTextures 2017-10-14 11:32:42 -04:00