Commit Graph

59 Commits (master)

Author SHA1 Message Date
Evil Eye 5a0aed3a78 Use more decomposition, string_view, and implicit sizes in ESM code 9 months ago
Evil Eye 6b7e7acd16 Replace a number of incorrect index types 2 years ago
florent.teppe f99e65843a Removes most cellId.hpp include, simplifies id generation for cells. 2 years ago
florent.teppe c2182c2fcc Get Rid of ESM::CellId almost everywhere
it was a competing concept from using RefIds for cell.
There is almost no point to it now, except to load older data.
2 years ago
florent.teppe c39dd576f8 Gets rid of most ESM::CellId 2 years ago
Evil Eye 54d6fb29c2 Don't store a save's cell name as a RefID 2 years ago
elsid 080700f8fe
Name all custom ESM format versions and add tests 2 years ago
florent.teppe 65cdd489fb create a specific esm reader function for RefID to avoid allocation for string and then again for RefId
Fixed some types

removed useless header

applied clang format

fixed compile tests

fixed clang tidy, and closer to logic before this MR

Removed hardcoded refids

unless there is a returned value we don't use static RefIds
can use == between RefId and hardcoded string

Fix clang format

Fixed a few instances where std::string was used, when only const std::string& was needed

removed unused variable
2 years ago
fteppe 62d8fe3fc2 changed a few hardcoded refIds used in mutliple places to be defined only once in a variable 2 years ago
fteppe 20da0892ef openMW_test_suite compiles and runs
Slowly moving through the open-cs errors

Good progress in openCS

Very good progress on openCS

Getting closer with openCS

OpenCS compiles and runs! Didn't have time to test it all though

ix openMW

everything compiles on windows??

Fix gcc

Fix Clang
2 years ago
clang-format-bot ddb0522bbf
Apply clang-format to code base 2 years ago
Project579 c226b35f1f Fix some remaining encoding errors due to std::filesystem transition. 2 years ago
Project579 199bf233e8 essimporter: Don't use "std::string" to store paths. 2 years ago
Andrei Kortunov 03cdffb555 Init some missing variables 3 years ago
Evil Eye c231c3e360 Replace new with make_unique in essimporter 3 years ago
jvoisin 4e4debb1cb Remove even more of boost::filesystem 3 years ago
elsid ec3674b40a
Use unique_ptr instead of shared_ptr
for MWWorld::Action, ProjectileManager and ESSImport::Converter.

shared_ptr has additional cost of reference counter and requires additional
allocation when constructed as shared_ptr<T>(new T).
3 years ago
duncanspumpkin 3a117cac22 Switch to a constexpr for FourCC constant
Add static asssert on wrong size
3 years ago
Bret Curtis 74e7cfc023 remove unused includes: part1
remove unused imports: part2

revert one tidy we will keep for c++20
3 years ago
Bret Curtis d1fb854521 move most of the files from esm to esm3, keep common code in esm; this is make space for a future with esm4
esm typo

esm typo
3 years ago
elsid 18d3102148
Do not use union to access FIXED_STRING<4> as int
https://en.cppreference.com/w/cpp/language/union:
> It's undefined behavior to read from the member of the union that wasn't most recently written.
3 years ago
Thunderforge ded7bd92e6 Using auto keyword in most apps
Detected by clang-tidy's modernize-use-auto
4 years ago
Andrei Kortunov aacb569acb Use more C++11 in tools code 5 years ago
Andrei Kortunov 3704acf857 Unify streams usage to support non-ASCII paths (bug #5239) 5 years ago
Andrei Kortunov 70ed8fd1a9 Use constants instead of widely used magic numbers (task #4645) 6 years ago
Alf Henrik Sauge feeee50a88 Dropping a separate NPDTstruct12 object and instead use NPDTstruct52
NPDTstruct12 is now only used when loading and saving. Turning auto calc
on and off now no longer switches between to different set of values
7 years ago
MiroslavR f15de6d3ca ESS-Importer: Convert magic projectiles (Closes #2320) 7 years ago
MiroslavR 6e869c3123 ESS-Importer: Convert ballistic projectiles (Feature #2320) 7 years ago
Bret Curtis c781d1f8ed purge unnecessary imports
add fstream back

add fstream back

add fstream back

add fstream back

add fstream back

add fstream back

add fstream back
8 years ago
Bret Curtis 39185e6f8c purge the rest of boost::shared and any other boost related things that no longer are required
put boost system back in, clean others up

revert Qt

add back boost fstream
8 years ago
scrawl 29556a1802 More consistent wording of errors/warnings
A Warning indicates a potential problem in the content file(s) that the user told OpenMW to load. E.g. this might cause an object to not display at all or as intended, however the rest of the game will run fine.

An Error, however, is more likely to be a bug with the engine itself - it means that basic assumptions have been violated and the engine might not run correctly anymore.

The above mostly applies to errors/warnings during game-play; startup issues are handled differently: when a file is completely invalid/corrupted to the point that the engine can not start, that might cause messages that are worded as Error due to the severity of the issue but are not necessarily the engine's fault.

Hopefully, being a little more consistent here will alleviate confusion among users as to when a log message should be reported and to whom.
8 years ago
Allofich c7313606f5 Fix dereference of null pointer warning 8 years ago
MiroslavR f3ce0840be Import controls state from vanilla savegames 8 years ago
Roman Proskuryakov d5dfa89060 Rewrite NAME_T into FIXED_STRING. 9 years ago
scrawl daa94cc50e Fix cppcheck warnings 9 years ago
Stanislav Bas 6b21da7f8e Rework ESS importer code. Remove explicit NAME handling for ESM records 10 years ago
scrawl 0ed3e3e489 Fix cout/cerr mixup 10 years ago
scrawl 24ae1d5ace Fix some issues found by coverity 10 years ago
scrawl 2065e0fa2d Use the correct format specifier for ess-imported savegames 10 years ago
scrawl 4bb3cbf0fb Remove last remains of Ogre 10 years ago
scrawl 364b785e8f ESSImporter image conversions port to osg::Image 10 years ago
scrawl 2e4b5858e7 ESSImport: add ANSI color code highlighting for --compare switch 10 years ago
scrawl 081c8c8615 ESSImport: convert to utf8, based on encoding setting in openmw.cfg 10 years ago
dteviot 70e4f821ba Fix Windows warning
warning C4244: 'initializing' : conversion from 'float' to 'int', possible loss of data
10 years ago
dteviot b0b275a936 Fix for MSVC 2013 compiler issues.
Fixes: C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\include\utility(199): error C2079: 'std::pair<const _Kty,_Ty>::second' uses undefined class 'boost::shared_ptr<ESSImport::Converter>'
Which cascades to 36 more errors.
10 years ago
scrawl b1bd236345 ESSImport: convert script local variables
Had to add special reading code to openmw, because the variable names are not stored.
10 years ago
scrawl e484a91708 ESSImport: convert global map markers 10 years ago
scrawl 1d29180e00 ESSImport: handle deleted cell references 10 years ago
scrawl e203127952 ESSImport: read script variables (not converted yet) 10 years ago
scrawl 1e92cab3e7 ESSImport: read dialogue/journal records, not converted yet 10 years ago